[hat] Enable vendor information to be pass to the code-generators#1006
[hat] Enable vendor information to be pass to the code-generators#1006jjfumero wants to merge 4 commits intoopenjdk:code-reflectionfrom
Conversation
|
👋 Welcome back jfumero! A progress list of the required criteria for merging this PR into |
|
@jjfumero This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/template append |
|
@jjfumero The pull request template has been appended to the pull request body |
|
|
||
| public Vendor getDeviceVendor() { | ||
| MemorySegment vendorNameSegment = getVendorFunction.invoke(handle); | ||
| long sizeString = stringFunctionLength.invoke(vendorNameSegment); |
There was a problem hiding this comment.
We created a memorySegment just for the Vendor Name?
Maybe we can create a MemorSegment with some structure. To receive other vendor info later.
So maybe a MemorySegment containing a list of Name/Value/Type triples
We can a MappedMemorySegment then for all values....
grfrost
left a comment
There was a problem hiding this comment.
I think we might take this opportunity to provide a mechanism for retrieving future vendor/device/status information using a single MemorySegment mapped to an IfaceMapped segment.
This PR enables vendor information to be used in the code generators.
All tests must pass:
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/1006/head:pull/1006$ git checkout pull/1006Update a local copy of the PR:
$ git checkout pull/1006$ git pull https://git.openjdk.org/babylon.git pull/1006/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1006View PR using the GUI difftool:
$ git pr show -t 1006Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/1006.diff
Using Webrev
Link to Webrev Comment