Skip to content

[hat] Roll back tensors from the main branch#1012

Closed
jjfumero wants to merge 1 commit intoopenjdk:code-reflectionfrom
jjfumero:hat/remove/tensors
Closed

[hat] Roll back tensors from the main branch#1012
jjfumero wants to merge 1 commit intoopenjdk:code-reflectionfrom
jjfumero:hat/remove/tensors

Conversation

@jjfumero
Copy link
Copy Markdown
Member

@jjfumero jjfumero commented Apr 27, 2026

Revert PR #998

Since tensor support is still work in progress, this PR temporary removes the tensors from the main branch.

All tests should pass for both supported backends (OpenCL and CUDA) without the Tensors support.

This PR keeps the fix for the data-flow tagging (Buffer Tagger) as RO by default.



Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/1012/head:pull/1012
$ git checkout pull/1012

Update a local copy of the PR:
$ git checkout pull/1012
$ git pull https://git.openjdk.org/babylon.git pull/1012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1012

View PR using the GUI difftool:
$ git pr show -t 1012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/1012.diff

Using Webrev

Link to Webrev Comment

@jjfumero jjfumero requested a review from grfrost April 27, 2026 08:35
@jjfumero jjfumero self-assigned this Apr 27, 2026
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 27, 2026

👋 Welcome back jfumero! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 27, 2026

@jjfumero This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

[hat] Roll back tensors from the main branch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the code-reflection branch:

  • e12e6dc: Updates to specification and API
  • 5125e6c: BytecodeGenerator constructor with varargs fix + test

Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@jjfumero
Copy link
Copy Markdown
Member Author

/template append

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 28, 2026

@jjfumero The pull request template has been appended to the pull request body

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 28, 2026

Webrevs

@jjfumero
Copy link
Copy Markdown
Member Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 28, 2026

Going to push as commit 774621b.
Since your change was applied there have been 2 commits pushed to the code-reflection branch:

  • e12e6dc: Updates to specification and API
  • 5125e6c: BytecodeGenerator constructor with varargs fix + test

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Apr 28, 2026
@openjdk openjdk Bot closed this Apr 28, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 28, 2026

@jjfumero Pushed as commit 774621b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant