7903774: make all tests combinations printing nicer and/or configurable #153

judovana · 2024-11-14T16:45:30Z

This is still WIP, but already on row what CODETOOLS-7903774 suggested.

It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable.

From:

`TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149
`COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact
`ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149
`COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910
`COMBINATIONS_JSON` same as combinations, but a valid json
`COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed

TESTS are already implemented as ALL_MATCHING
COMBINATIONS as ALL_MATCHING_COMBINATIONS
ALL_TESTS as ALL

COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development.
The _JSON variants are tobe decided, but ability to JQL it sounds nice.

Suggestion to better names welcomed.

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

CODETOOLS-7903774: make all tests combinations printing nicer and/or configurable (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153
$ git checkout pull/153

Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.org/jcstress.git pull/153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 153

View PR using the GUI difftool:
$ git pr show -t 153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/153.diff

Using Webrev

Link to Webrev Comment

instead of misusing verbose switch and thus returned the ability to print allavailable tetest

bridgekeeper · 2024-11-14T16:46:02Z

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-11-14T16:46:20Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

mlbridge · 2024-11-14T16:49:03Z

Webrevs

judovana · 2024-11-15T17:47:29Z

Implemented
COMBINATIONS_GROUPED and COMBINATIONS_GROUPS (as MATCHING_GROUPS and MATCHING_GROUPS_COUNT) also with its inverted variants

The nice json will maybe need some refactorings. WIP on it, but any feedback appreciated

bridgekeeper · 2024-12-13T20:50:01Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2024-12-14T19:29:23Z

I intend to finish this. Still some feedback if it is even desired, and selected approach is ok, would be nice.

To cut away the header one can use: | sed '0,/^All.*[0-9]\+$/d'

openjdk · 2024-12-23T13:45:45Z

@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

if true, the key will be written as: "[actor1, actor2], spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB: 64, compileMode: 7, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256, strideCount: 40, cpuMap: null, [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]" otherwise (default), it will be written as ... "actorNames": ["actor1", "actor2"], "spinLoopStyle": "Thread.onSpinWait()", "threads": 2, "forkId": 0, "maxFootprintMB": 64, "compileMode": 7, "shClass": "(PG 0, CG 0), (PG 0, CG 0)", "strideSize": 256, "strideCount": 40, "cpuMap": "null", "jvmArgs": [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]" ...

- id can be used both flatten (so equal to plaintext) or properly strcutured for JQ (default) - listing can be redirecd to stderr to use with `jq` directly

judovana · 2024-12-30T16:50:48Z

hi @shipilev ! This is now feature complete for #149 (comment) what do you think?

bridgekeeper · 2025-01-27T21:00:55Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-02-01T17:29:43Z

...keep live...

judovana · 2025-02-03T12:27:40Z

Just small recap, why this is done - I wanted to split full load of jcstresses, into several HWs. At least 50, so it can finish in reasonable time. This splitting is done by groups - eg https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml#L1128 - to have those groups equally split, information provided by this PR have to be reasonably accessible.

bridgekeeper · 2025-03-03T13:52:38Z

@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

judovana · 2025-03-03T14:09:43Z

More are on the way!

judovana added 2 commits November 14, 2024 17:39

refactored listTests() to its own class

e2dcda6

Refactored lsiting so it takes proper argument

d8a3644

instead of misusing verbose switch and thus returned the ability to print allavailable tetest

judovana changed the title ~~CODETOOLS-7903774~~ CODETOOLS-7903774 make all tests combinations printing nicer and/or configurable Nov 14, 2024

openjdk bot changed the title ~~CODETOOLS-7903774 make all tests combinations printing nicer and/or configurable~~ 7903774: make all tests combinations printing nicer and/or configurable Nov 14, 2024

openjdk bot added the rfr Pull request is ready for review label Nov 14, 2024

judovana marked this pull request as draft November 14, 2024 18:06

openjdk bot removed the rfr Pull request is ready for review label Nov 14, 2024

implemented MATCHING_(INVERTED)GROUPS(_COUNT)

0a2e6c7

judovana marked this pull request as ready for review November 15, 2024 17:46

openjdk bot added the rfr Pull request is ready for review label Nov 15, 2024

judovana added 2 commits November 15, 2024 18:50

Removed redundnant hyphen

a58cd14

Fixed spacing in help

67b737b

judovana added 2 commits December 23, 2024 12:49

Implemented totaling of listing only

5006dea

Implemented naive json formatting

60bbb3e

To cut away the header one can use: | sed '0,/^All.*[0-9]\+$/d'

judovana force-pushed the betterLsiting branch from 0219ab9 to 60bbb3e Compare December 23, 2024 13:45

judovana added 3 commits December 23, 2024 17:06

ALL now corectly return all tests

8c94911

Implemented proper json listings

b8d0209

- id can be used both flatten (so equal to plaintext) or properly strcutured for JQ (default) - listing can be redirecd to stderr to use with `jq` directly

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7903774: make all tests combinations printing nicer and/or configurable #153

7903774: make all tests combinations printing nicer and/or configurable #153

judovana commented Nov 14, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 14, 2024

openjdk bot commented Nov 14, 2024

mlbridge bot commented Nov 14, 2024 •

edited

Loading

judovana commented Nov 15, 2024

bridgekeeper bot commented Dec 13, 2024

judovana commented Dec 14, 2024

openjdk bot commented Dec 23, 2024

judovana commented Dec 30, 2024

bridgekeeper bot commented Jan 27, 2025

judovana commented Feb 1, 2025

judovana commented Feb 3, 2025

bridgekeeper bot commented Mar 3, 2025

judovana commented Mar 3, 2025

7903774: make all tests combinations printing nicer and/or configurable #153

Are you sure you want to change the base?

7903774: make all tests combinations printing nicer and/or configurable #153

Conversation

judovana commented Nov 14, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewing

bridgekeeper bot commented Nov 14, 2024

openjdk bot commented Nov 14, 2024

mlbridge bot commented Nov 14, 2024 • edited Loading

Webrevs

judovana commented Nov 15, 2024

bridgekeeper bot commented Dec 13, 2024

judovana commented Dec 14, 2024

openjdk bot commented Dec 23, 2024

judovana commented Dec 30, 2024

bridgekeeper bot commented Jan 27, 2025

judovana commented Feb 1, 2025

judovana commented Feb 3, 2025

bridgekeeper bot commented Mar 3, 2025

judovana commented Mar 3, 2025

judovana commented Nov 14, 2024 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 14, 2024 •

edited

Loading