-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903754: jcstress should die asap - with report - on broken jvm/hw, instead of waiting on kill #157
base: master
Are you sure you want to change the base?
Conversation
…nstead of waiting on kill Initial PoC
👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
The PR is now moreover done. I will run it through even ore testing through. |
Webrevs
|
} | ||
|
||
private void verifyState(TestResult r) { | ||
long totalFailed = failed + hardErrors; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the softErrors
should be counted in? Maybe configurable by some property? wdyt?
@judovana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
More are on the way! |
Initial PoC
It currently show how to set up argument, and how the framework will be terminated. Feedback welcomed. Should be finished soon
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/157/head:pull/157
$ git checkout pull/157
Update a local copy of the PR:
$ git checkout pull/157
$ git pull https://git.openjdk.org/jcstress.git pull/157/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 157
View PR using the GUI difftool:
$ git pr show -t 157
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/157.diff
Using Webrev
Link to Webrev Comment