7903671: jcstress: Update buffer tests for JDK-8318966 #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 1: Detecting jdk of target VM and exuding illegible tests
This is prequel to full fixing of CODETOOLS-7903671. This PR detects target JDK version and then disables illegible tests.
part 2 will be done in templates of affected tests and logic around generating the classes from them. In meantime this should server.
The jdk detection will be most likely used anyway. WDYT? If we agree on similar approach, I will create a new bug for this PR only.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/159/head:pull/159
$ git checkout pull/159
Update a local copy of the PR:
$ git checkout pull/159
$ git pull https://git.openjdk.org/jcstress.git pull/159/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 159
View PR using the GUI difftool:
$ git pr show -t 159
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/159.diff
Using Webrev
Link to Webrev Comment