Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903671: jcstress: Update buffer tests for JDK-8318966 #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

judovana
Copy link

@judovana judovana commented Feb 26, 2025

part 1: Detecting jdk of target VM and exuding illegible tests

This is prequel to full fixing of CODETOOLS-7903671. This PR detects target JDK version and then disables illegible tests.
part 2 will be done in templates of affected tests and logic around generating the classes from them. In meantime this should server.

The jdk detection will be most likely used anyway. WDYT? If we agree on similar approach, I will create a new bug for this PR only.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/159/head:pull/159
$ git checkout pull/159

Update a local copy of the PR:
$ git checkout pull/159
$ git pull https://git.openjdk.org/jcstress.git pull/159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 159

View PR using the GUI difftool:
$ git pr show -t 159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/159.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2025

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 26, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 7903671: jcstress: Update buffer tests for JDK-8318966 7903671: jcstress: Update buffer tests for JDK-8318966 Feb 26, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 26, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 26, 2025

Webrevs

@judovana
Copy link
Author

judovana commented Mar 3, 2025

I made a much more deeper look, and consulted with Aph and Thomas, and it seems that for jdk 23 and up, the correct replacement are direct buffers - which - feel free to correct me - are well covered in jcstress,

Thus the buffer tests should be conditionally excluded, as here, or removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant