8351167: ZGC: Lazily initialize livemap #23907
Open
+24
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory for the bitmap inside the livemap of a ZPage is currently allocated upon calling its constructor, which adds a latency overhead when allocating pages. As preparation for the Mapped Cache (JDK-8350441), but also as a standalone improvement, we want to instead lazily initialize the livemap's bitmap.
This patch holds off with allocating memory for the bitmap that the livemap uses until the livemap is written to the first time (i.e. by calling ZLiveMap::set). The effect of this is that the latency impact of allocating the bitmap will only be taken by GC threads and not by mutator threads, since only GC threads mark objects before pushing them onto the mark stack. This improvement will reduce page allocation latencies somewhat.
In addition to lazily allocating the bitmap, I've converted the static C-style cast to a checked cast for
ZPage::object_max_count()
, which is passed as the size to the bitmaps. This is because a value not contained in 32 bits will overflow with the C-style cast and give a too small bitmap when passed to the livemap. This is not an observed issue, just more of a sanity check.Testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23907/head:pull/23907
$ git checkout pull/23907
Update a local copy of the PR:
$ git checkout pull/23907
$ git pull https://git.openjdk.org/jdk.git pull/23907/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23907
View PR using the GUI difftool:
$ git pr show -t 23907
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23907.diff
Using Webrev
Link to Webrev Comment