Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351167: ZGC: Lazily initialize livemap #23907

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsikstro
Copy link
Member

@jsikstro jsikstro commented Mar 4, 2025

Memory for the bitmap inside the livemap of a ZPage is currently allocated upon calling its constructor, which adds a latency overhead when allocating pages. As preparation for the Mapped Cache (JDK-8350441), but also as a standalone improvement, we want to instead lazily initialize the livemap's bitmap.

This patch holds off with allocating memory for the bitmap that the livemap uses until the livemap is written to the first time (i.e. by calling ZLiveMap::set). The effect of this is that the latency impact of allocating the bitmap will only be taken by GC threads and not by mutator threads, since only GC threads mark objects before pushing them onto the mark stack. This improvement will reduce page allocation latencies somewhat.

In addition to lazily allocating the bitmap, I've converted the static C-style cast to a checked cast for ZPage::object_max_count(), which is passed as the size to the bitmaps. This is because a value not contained in 32 bits will overflow with the C-style cast and give a too small bitmap when passed to the livemap. This is not an observed issue, just more of a sanity check.

Testing:

  • Tiers 1-5
  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351167: ZGC: Lazily initialize livemap (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23907/head:pull/23907
$ git checkout pull/23907

Update a local copy of the PR:
$ git checkout pull/23907
$ git pull https://git.openjdk.org/jdk.git pull/23907/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23907

View PR using the GUI difftool:
$ git pr show -t 23907

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23907.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2025

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2025
@openjdk
Copy link

openjdk bot commented Mar 4, 2025

@jsikstro The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Mar 4, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant