Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) #23909

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Mar 4, 2025

Back in JDK 21 we deprecated-for-removal SynthLookAndFeel.load(URL) and targeted it to be removed under this bug ID in JDK 25 .. which is now here.

No open tests needed to be updated to accommodate this removal
I did find one closed manual test, written to explicitly test this API back when it was added, and I'll need to remove that, but it doesn't affect this PR.

There will be a CSR (and probably a release note too).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8351238 to be approved

Issues

  • JDK-8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) (Bug - P4)
  • JDK-8351238: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23909/head:pull/23909
$ git checkout pull/23909

Update a local copy of the PR:
$ git checkout pull/23909
$ git pull https://git.openjdk.org/jdk.git pull/23909/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23909

View PR using the GUI difftool:
$ git pr show -t 23909

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23909.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8319192 8319192: Mar 4, 2025
@openjdk
Copy link

openjdk bot commented Mar 4, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@prrace
Copy link
Contributor Author

prrace commented Mar 4, 2025

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Mar 4, 2025
@openjdk
Copy link

openjdk bot commented Mar 4, 2025

@prrace has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@prrace this pull request must refer to an issue in JBS to be able to link it to a CSR request. To refer this pull request to an issue in JBS, please update the title of this pull request to just the issue ID.

@prrace prrace changed the title 8319192: 8319192 Mar 4, 2025
@openjdk openjdk bot changed the title 8319192 8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) Mar 4, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2025

Webrevs

@azvegint
Copy link
Member

azvegint commented Mar 5, 2025

It is also mentioned in

<a href="../../../../../javax/swing/plaf/synth/SynthLookAndFeel.html#load(java.net.URL)">
SynthLookAndFeel.load(URL)</a> methods.

@prrace
Copy link
Contributor Author

prrace commented Mar 5, 2025

It is also mentioned in

<a href="../../../../../javax/swing/plaf/synth/SynthLookAndFeel.html#load(java.net.URL)">
SynthLookAndFeel.load(URL)</a> methods.

Ah. I'd forgotten that. I had updated it back in JDK 21 but it slipped my mind this time round.

I'll remove the relevant text.
Hmm, is that specific text part of the spec needed for the CSR ? I didn't include it in the JDK 21 case, and it seems to be just examples, so I am going to say no.

@prrace
Copy link
Contributor Author

prrace commented Mar 5, 2025

It is also mentioned in

<a href="../../../../../javax/swing/plaf/synth/SynthLookAndFeel.html#load(java.net.URL)">
SynthLookAndFeel.load(URL)</a> methods.

Ah. I'd forgotten that. I had updated it back in JDK 21 but it slipped my mind this time round.

fixed

@@ -34,7 +34,6 @@
import java.io.BufferedInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is URLClassLoader no longer used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems so. I'll remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants