-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) #23909
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
/csr |
@prrace has indicated that a compatibility and specification (CSR) request is needed for this pull request. @prrace this pull request must refer to an issue in JBS to be able to link it to a CSR request. To refer this pull request to an issue in JBS, please update the title of this pull request to just the issue ID. |
Webrevs
|
It is also mentioned in jdk/src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html Lines 57 to 58 in caaf409
|
Ah. I'd forgotten that. I had updated it back in JDK 21 but it slipped my mind this time round. I'll remove the relevant text. |
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java
Outdated
Show resolved
Hide resolved
fixed |
@@ -34,7 +34,6 @@ | |||
import java.io.BufferedInputStream; | |||
import java.io.IOException; | |||
import java.io.InputStream; | |||
import java.net.MalformedURLException; | |||
import java.net.URL; | |||
import java.net.URLClassLoader; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is URLClassLoader no longer used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems so. I'll remove it.
Back in JDK 21 we deprecated-for-removal SynthLookAndFeel.load(URL) and targeted it to be removed under this bug ID in JDK 25 .. which is now here.
No open tests needed to be updated to accommodate this removal
I did find one closed manual test, written to explicitly test this API back when it was added, and I'll need to remove that, but it doesn't affect this PR.
There will be a CSR (and probably a release note too).
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23909/head:pull/23909
$ git checkout pull/23909
Update a local copy of the PR:
$ git checkout pull/23909
$ git pull https://git.openjdk.org/jdk.git pull/23909/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23909
View PR using the GUI difftool:
$ git pr show -t 23909
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23909.diff
Using Webrev
Link to Webrev Comment