8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

[ericcaspole]

The normal SQE process runs all the repo JMH with -ea to get the last bit of extra testing. This DremFrem JMH contained some asserts that would always fire on the correct answer, disturbing this normal SQE process. I removed a lot more asserts from this JMH which seemed to make it more of a SQE test than a benchmark. We would prefer to keep benchmarks as benchmarks as much as possible and not creep into tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer) 🔄 Re-review required (review applies to 8c882666)
• Joe Darcy (@jddarcy - Reviewer) 🔄 Re-review required (review applies to 8c882666)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23917/head:pull/23917
$ git checkout pull/23917

Update a local copy of the PR:
$ git checkout pull/23917
$ git pull https://git.openjdk.org/jdk.git pull/23917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23917

View PR using the GUI difftool:
$ git pr show -t 23917

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23917.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ericcaspole This change is no longer ready for integration - check the PR body for details.

[openjdk]

@ericcaspole To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[ericcaspole]

/label core-libs compiler

[openjdk]

@ericcaspole
The core-libs label was successfully added.

The compiler label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (649957dc)
• 00: Full (8c882666)

[liach]

@ericcaspole Do you mean hotspot-compiler for the label instead of javac?

[liach]

These benchmarks are malformed indeed; the blackhole is never used.

[liach]

Also might need to add an 2025 copyright header for this file.

[ericcaspole]

Thanks @liach I removed the unused Blackhole and updated the copyright header.