Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337593: Using actual RegisterMap instead of copy #23918

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neethu-prasad
Copy link
Contributor

@neethu-prasad neethu-prasad commented Mar 5, 2025

[Not ready. Work in progress. Draft pull request to verify tests]
Notes:
On a sample application's profiler using VM_ThreadDump, 24.52% (of VM thread) CPU cycle was spent on copying RegisterMap. Pass by value seems to perform better.

RegisterMap temp_map = *register_map();

Testing

  1. tier 1 / tier 2 tests passed.

Appreciate feedback incase there is impact to other VM operations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8337593

Issue

  • JDK-8337593: Investigate VM_ThreadDump performance (Enhancement - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23918/head:pull/23918
$ git checkout pull/23918

Update a local copy of the PR:
$ git checkout pull/23918
$ git pull https://git.openjdk.org/jdk.git pull/23918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23918

View PR using the GUI difftool:
$ git pr show -t 23918

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23918.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2025

👋 Welcome back nprasad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

@neethu-prasad The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@neethu-prasad neethu-prasad changed the title 834130: Using actual RegisterMap instead of copy 8341481: Using actual RegisterMap instead of copy Mar 5, 2025
@neethu-prasad neethu-prasad changed the title 8341481: Using actual RegisterMap instead of copy 8337593: Using actual RegisterMap instead of copy Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant