8337593: Using actual RegisterMap instead of copy #23918
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Not ready. Work in progress. Draft pull request to verify tests]
Notes:
On a sample application's profiler using VM_ThreadDump, 24.52% (of VM thread) CPU cycle was spent on copying RegisterMap. Pass by value seems to perform better.
jdk/src/hotspot/share/runtime/vframe.cpp
Line 97 in 5dc9723
Testing
Appreciate feedback incase there is impact to other VM operations.
Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23918/head:pull/23918
$ git checkout pull/23918
Update a local copy of the PR:
$ git checkout pull/23918
$ git pull https://git.openjdk.org/jdk.git pull/23918/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23918
View PR using the GUI difftool:
$ git pr show -t 23918
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23918.diff