Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351216: ZGC: Store NUMA node count #23922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsikstro
Copy link
Member

@jsikstro jsikstro commented Mar 5, 2025

To avoid calling into os::Linux::max_numa_node() and in turn libnuma on every count lookup, I propose we instead store the count statically inside ZNUMA. This is perfectly fine since the value that we get from libnuma is configured once during initialization and never change during runtime.

The count is set during platform dependent initialization and the getter is now defined in the common code in ZNUMA.cpp. On operating systems that ZGC does not support NUMA for (BSD and Windows) we keep the current behavior by setting the count to 1.

This is also preparation work for the Mapped Cache (JDK-8350441).

Testing:

  • Tiers 1-3
  • GHA
  • Verify that the count is set on a Linux system with NUMA hardware

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351216: ZGC: Store NUMA node count (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23922/head:pull/23922
$ git checkout pull/23922

Update a local copy of the PR:
$ git checkout pull/23922
$ git pull https://git.openjdk.org/jdk.git pull/23922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23922

View PR using the GUI difftool:
$ git pr show -t 23922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23922.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2025

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2025
@openjdk
Copy link

openjdk bot commented Mar 5, 2025

@jsikstro The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@jsikstro jsikstro changed the title 8351216: Store NUMA node count 8351216: ZGC: Store NUMA node count Mar 5, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2025

Webrevs

@jsikstro
Copy link
Member Author

jsikstro commented Mar 6, 2025

/label add hotspot-gc
/label remove hotspot

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@jsikstro
The hotspot-gc label was successfully added.

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@jsikstro
The hotspot label was successfully removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant