8351216: ZGC: Store NUMA node count #23922
Open
+15
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid calling into
os::Linux::max_numa_node()
and in turn libnuma on every count lookup, I propose we instead store the count statically inside ZNUMA. This is perfectly fine since the value that we get from libnuma is configured once during initialization and never change during runtime.The count is set during platform dependent initialization and the getter is now defined in the common code in ZNUMA.cpp. On operating systems that ZGC does not support NUMA for (BSD and Windows) we keep the current behavior by setting the count to 1.
This is also preparation work for the Mapped Cache (JDK-8350441).
Testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23922/head:pull/23922
$ git checkout pull/23922
Update a local copy of the PR:
$ git checkout pull/23922
$ git pull https://git.openjdk.org/jdk.git pull/23922/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23922
View PR using the GUI difftool:
$ git pr show -t 23922
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23922.diff
Using Webrev
Link to Webrev Comment