8350194: Last 2 parameters of ReturnNode::ReturnNode are swapped in the declaration

[mhaessig]

The last two parameters in the declaration of ReturnNode::ReturnNode, frameptr and retadr were swapped in the declaration compared to the definition. This commit makes the declaration consistent with the definition and the two usages in GraphKit::gen_stub() and Compile::return_values().

Tests: tiers 1 through 3 passed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

• JDK-8350194: Last 2 parameters of ReturnNode::ReturnNode are swapped in the declaration (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23927/head:pull/23927
$ git checkout pull/23927

Update a local copy of the PR:
$ git checkout pull/23927
$ git pull https://git.openjdk.org/jdk.git pull/23927/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23927

View PR using the GUI difftool:
$ git pr show -t 23927

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23927.diff

[bridgekeeper]

Hi @mhaessig, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user mhaessig" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mhaessig]

/covered

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[TobiHartmann]

That looks good and trivial to me. Congratulations on your first PR Manuel! 🥳