Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350485: C2: factor out common code in Node::grow() and Node::out_grow() #23928

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sarannat
Copy link

@sarannat sarannat commented Mar 6, 2025

Node:grow() and Node::out_grow() are copy-pasted from each other and their core logic could be factored out into a third function or at least cleaned up. Hence,the fix includes a function Node::array_resize() that implements the core logic of Node::grow() and Node::out_grow().

Link to Github action which had no failures : https://github.com/sarannat/jdk/actions/runs/13677508359


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8350485: C2: factor out common code in Node::grow() and Node::out_grow() (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23928/head:pull/23928
$ git checkout pull/23928

Update a local copy of the PR:
$ git checkout pull/23928
$ git pull https://git.openjdk.org/jdk.git pull/23928/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23928

View PR using the GUI difftool:
$ git pr show -t 23928

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23928.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Mar 6, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2025

Hi @sarannat, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user sarannat" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@sarannat The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@sarannat sarannat changed the title JDK 8350485 JDK 8350485: C2: factor out common code in Node::grow() and Node::out_grow() Mar 6, 2025
@sarannat sarannat changed the title JDK 8350485: C2: factor out common code in Node::grow() and Node::out_grow() 8350485: C2: factor out common code in Node::grow() and Node::out_grow() Mar 6, 2025
@sarannat
Copy link
Author

sarannat commented Mar 6, 2025

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Mar 6, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant