-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8348986: Improve coverage of enhanced exception messages #23929
base: master
Are you sure you want to change the base?
8348986: Improve coverage of enhanced exception messages #23929
Conversation
👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@Michael-Mc-Mahon The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/csr needed |
@Michael-Mc-Mahon has indicated that a compatibility and specification (CSR) request is needed for this pull request. @Michael-Mc-Mahon please create a CSR request for issue JDK-8348986 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
from turbanoff review Co-authored-by: Andrey Turbanov <[email protected]>
Hi,
Enhanced exception messages are designed to hide sensitive information such as hostnames, IP
addresses from exception message strings, unless the enhanced mode for the specific category
has been explicitly enabled. Enhanced exceptions were first introduced in 8204233 in JDK 11 and
updated in 8207846.
This PR aims to increase the coverage of enhanced exception messages in the networking code.
A limited number of exceptions are already hidden (restricted) by default. The new categories and
exceptions in this PR will be restricted on an opt-in basis, ie. the default mode will be enhanced
(while preserving the existing behavior).
The mechanism is controlled by the security/system property "jdk.includeInExceptions" which takes as value
a comma separated list of category names, which identify groups of exceptions where the exception
message may be enhanced. Any category not listed is "restricted" which means that potentially
sensitive information (such as hostnames, IP addresses, user identities) are excluded from the message text.
The changes to the java.security conf file describe the exact changes in terms of the categories now
supported and any changes in behavior.
Thanks,
Michael
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23929/head:pull/23929
$ git checkout pull/23929
Update a local copy of the PR:
$ git checkout pull/23929
$ git pull https://git.openjdk.org/jdk.git pull/23929/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23929
View PR using the GUI difftool:
$ git pr show -t 23929
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23929.diff
Using Webrev
Link to Webrev Comment