-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Re-opened: Generic lowerBound() and upperBound() Utility Methods for Collections and Arrays with 100% Test Coverage #25059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @adi1103sh, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user adi1103sh" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
@adi1103sh The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/signed |
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
@adi1103sh This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/keepalive |
@adi1103sh The pull request is being re-evaluated and the inactivity timeout has been reset. |
This introduces fully tested, generic utility methods:
lowerBound() and upperBound() — for:
Collection
T[] (wrapper/object arrays)
Primitive arrays: int[], long[], char[], short[], float[], double[]
These methods are frequently used in DSA problems, competitive programming, and time-constrained interviews. While C++ developers have access to std::lower_bound and std::upper_bound via STL, Java developers are often forced to re-implement these manually each time — leading to redundancy, reduced productivity, and more boilerplate during contests.
🔥 Key Highlights:
🚀 Optimized binary search logic internally for performance-critical use cases
📦 Supports both object-based and primitive-based containers
📚 Added JavaDocs to all test methods for clarity
💡 Why This Matters:
Reduces friction for Java developers during competitive programming, hackathons, and technical interviews
Brings parity with C++ STL, avoiding time wasted on re-implementing well-known patterns
Enhances reusability in both DSA libraries and production codebases that rely on sorted datasets
Progress
Error
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25059/head:pull/25059
$ git checkout pull/25059
Update a local copy of the PR:
$ git checkout pull/25059
$ git pull https://git.openjdk.org/jdk.git pull/25059/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25059
View PR using the GUI difftool:
$ git pr show -t 25059
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25059.diff