8357689: Refactor JVMCI to enable replay compilation in Graal #25433
Conversation
|
👋 Welcome back pecimuth! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
| * | ||
| * @return a copy of the slot kinds array | ||
| */ | ||
| public JavaKind[] getSlotKinds() { |
There was a problem hiding this comment.
Keep in mind that slotKinds is being converted to a List. In that context, can we return the list without making a copy? Or is the caller expected to be able to mutate the return value?
| @@ -291,10 +292,12 @@ public boolean equals(Object o) { | |||
| } | |||
| if (o instanceof VirtualObject) { | |||
There was a problem hiding this comment.
Rename l to that and use pattern instanceof:
| if (o instanceof VirtualObject) { | |
| if (o instanceof VirtualObject that) { |
| * @return a copy of the array containing the Java kinds of the values or {@code null} if the | ||
| * values have not been initialized. | ||
| */ | ||
| public JavaKind[] getSlotKinds() { |
There was a problem hiding this comment.
Same comments as for BytecodeFrame.getSlotKinds. This applies to all other non-primitive array return values added by this PR.
| /** | ||
| * Returns a copy of the array of {@link ResolvedJavaMethod} objects representing the methods | ||
| * whose bytecodes were used as input to the compilation. If the compilation did not record | ||
| * method dependencies, this method returns {@code null}. Otherwise, the first element of the |
This PR introduces a few minor JVMCI refactorings to make replay compilation possible in the Graal compiler.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25433/head:pull/25433$ git checkout pull/25433Update a local copy of the PR:
$ git checkout pull/25433$ git pull https://git.openjdk.org/jdk.git pull/25433/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25433View PR using the GUI difftool:
$ git pr show -t 25433Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25433.diff