-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8351268: [JVMCI] Enhance JVMCI by leveraging modern Java features #25442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@mur47x111 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Please try come up with a jtreg test that prevents introduction of new JVMCI methods returning arrays. Some kind of white list approach is probably best. |
@@ -71,14 +71,13 @@ public final class BytecodeFrame extends BytecodePosition { | |||
* This field is intentionally exposed as a mutable array that a compiler may modify (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mutable array -> mutable list
@mur47x111 this pull request can not be integrated into git checkout JDK-8351268
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/MetaUtil.java
Outdated
Show resolved
Hide resolved
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/meta/LocalVariableTable.java
Outdated
Show resolved
Hide resolved
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotCompiledCode.java
Outdated
Show resolved
Hide resolved
…essed being false
Return unmodifiable list instead of new arrays.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25442/head:pull/25442
$ git checkout pull/25442
Update a local copy of the PR:
$ git checkout pull/25442
$ git pull https://git.openjdk.org/jdk.git pull/25442/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25442
View PR using the GUI difftool:
$ git pr show -t 25442
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25442.diff