JDK-8349077 : Rename GenerationCounters::update_all

[suchismith1993]

JBS Issue : JDK-8349077

we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity).

Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349077: Rename GenerationCounters::update_all (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25833/head:pull/25833
$ git checkout pull/25833

Update a local copy of the PR:
$ git checkout pull/25833
$ git pull https://git.openjdk.org/jdk.git pull/25833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25833

View PR using the GUI difftool:
$ git pr show -t 25833

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25833.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@suchismith1993 The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (7bb69a1d)
• 04: Full - Incremental (bd26817c)
• 03: Full - Incremental (88c41602)
• 02: Full - Incremental (59839a66)
• 01: Full - Incremental (419f3d5f)
• 00: Full (cf2d66d5)

[albertnetymk]

I believe the ticket was only about this method, which handles only capacity.

void GenerationCounters::update_all(size_t curr_capacity) {
  _current_size->set_value(curr_capacity);
}

However, in the patch, this method is renamed as well. Not sure if this is intentional.

void HSpaceCounters::update_all(size_t capacity, size_t used) {
  update_capacity(capacity);
  update_used(used);
}

[mur47x111]

Since the base is before the branch off, could you please merge master before integration and see if GHA still passes? This also helps us testing libgraal compilation.

[albertnetymk]

Thanks for the revision.

I believe the one in ZGenerationCounters can be removed now.

  void update_capacity(size_t capacity) {
    update_all(capacity);
  }