JDK-8349077 : Rename GenerationCounters::update_all

[suchismith1993]

JBS Issue : JDK-8349077

we found the method names update_all of the class GenerationCounters and its subclasses are not so good. It is better to rename it to something like update_capacity (such as ZGenerationCounters::update_capacity).

Update_capacity exists, since update_all updates the size and used , I found update_memory_state as a better name for this method.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349077: Rename GenerationCounters::update_all (Enhancement - P5)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25833/head:pull/25833
$ git checkout pull/25833

Update a local copy of the PR:
$ git checkout pull/25833
$ git pull https://git.openjdk.org/jdk.git pull/25833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25833

View PR using the GUI difftool:
$ git pr show -t 25833

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25833.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@suchismith1993 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349077: Rename GenerationCounters::update_all

Reviewed-by: ayang, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• f2ef809: 8354727: CompilationPolicy creates too many compiler threads when code cache space is scarce
• 1fa0905: 8359268: 3 JNI exception pending defect groups in 2 files
• f71d64f: 8360405: [PPC64] some environments don't support mfdscr instruction
• ... and 14 more: https://git.openjdk.org/jdk/compare/28e96e333b61dfe60a84a48ff59bdf10c529f8be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @stefank) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@suchismith1993 The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 09: Full - Incremental (ed4e2277)
• 08: Full - Incremental (860c9a7a)
• 07: Full - Incremental (f8ea505a)
• 06: Full - Incremental (eacbfcdd)
• 05: Full - Incremental (7bb69a1d)
• 04: Full - Incremental (bd26817c)
• 03: Full - Incremental (88c41602)
• 02: Full - Incremental (59839a66)
• 01: Full - Incremental (419f3d5f)
• 00: Full (cf2d66d5)

[albertnetymk]

I believe the ticket was only about this method, which handles only capacity.

void GenerationCounters::update_all(size_t curr_capacity) {
  _current_size->set_value(curr_capacity);
}

However, in the patch, this method is renamed as well. Not sure if this is intentional.

void HSpaceCounters::update_all(size_t capacity, size_t used) {
  update_capacity(capacity);
  update_used(used);
}

[mur47x111]

Since the base is before the branch off, could you please merge master before integration and see if GHA still passes? This also helps us testing libgraal compilation.

[albertnetymk]

Thanks for the revision.

I believe the one in ZGenerationCounters can be removed now.

  void update_capacity(size_t capacity) {
    update_all(capacity);
  }

[stefank]

Could you also delete line 67.

[stefank]

Or maybe even better just entirely delete ZGenerationCounters and replace its usages with GenerationCounters.

[suchismith1993]

@albertnetymk @stefank is the windows failures occurring on every PR today ?

[albertnetymk]

These two field names are not aligned any more.

[stefank]

I had the same comment as Albert, but my comment was still pending.

[stefank]

@suchismith1993 Are you working for Red Hat? If you are not you need to revert the changes to the Red Hat copyright lines.

[suchismith1993]

@suchismith1993 Are you working for Red Hat? If you are not you need to revert the changes to the Red Hat copyright lines.

I work for IBM, so I need to add a new line with IBM Corp ?

[stefank]

@suchismith1993 Are you working for Red Hat? If you are not you need to revert the changes to the Red Hat copyright lines.

I work for IBM, so I need to add a new line with IBM Corp ?

I think you need to ask your company about that.

[stefank]

Some extra info about copyrights:
https://openjdk.org/guide/#copyright-headers

[suchismith1993]

/integrate

[openjdk]

@suchismith1993
Your change (at version ed4e227) is now ready to be sponsored by a Committer.

[albertnetymk]

/sponsor

[openjdk]

Going to push as commit 52c6044.
Since your change was applied there have been 19 commits pushed to the master branch:

• 4e1bf31: 8360523: Parallel: Remove unused local variable in MutableNUMASpace::initialize
• 878497f: 8360178: TestArguments.atojulong gtest has incorrect format string
• f2ef809: 8354727: CompilationPolicy creates too many compiler threads when code cache space is scarce
• ... and 16 more: https://git.openjdk.org/jdk/compare/28e96e333b61dfe60a84a48ff59bdf10c529f8be...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk @suchismith1993 Pushed as commit 52c6044.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.