Skip to content

8359735: [Ubuntu 25.10] java/lang/ProcessBuilder/Basic.java, java/lang/ProcessHandle/InfoTest.java fail due to rust-coreutils #25838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vpa1977
Copy link
Contributor

@vpa1977 vpa1977 commented Jun 16, 2025

To accommodate systems like Ubuntu 25.10 that use Rust coreutils, this PR updates tests that previously assumed BusyBox was the only environment to use symlinks for core utilities.

Changes:

  • java/lang/ProcessBuilder/Basic.java: The test is updated to simply verify that /bin/true and /bin/false are symlinks, removing the hardcoded check for a /bin/busybox target.
  • java/lang/ProcessHandle/InfoTest.java: The test logic is relaxed. It now confirms that /bin/sleep is a symlink and then uses the symlink's target as the expected executable name.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359735: [Ubuntu 25.10] java/lang/ProcessBuilder/Basic.java, java/lang/ProcessHandle/InfoTest.java fail due to rust-coreutils (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25838/head:pull/25838
$ git checkout pull/25838

Update a local copy of the PR:
$ git checkout pull/25838
$ git pull https://git.openjdk.org/jdk.git pull/25838/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25838

View PR using the GUI difftool:
$ git pr show -t 25838

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25838.diff

Using Webrev

Link to Webrev Comment

vpa1977 added 2 commits June 17, 2025 10:30
Busybox and rust coreutils create symlinks to the single executable.
Test that /bin/true and /bin/false are symlinks instead of
checking that they are linked to /bin/busybox.
busybox and rust coreutils link to the single executable.
Relax test condition to check that /bin/sleep is a symlink
and read the expected file name from the symlink.
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2025

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359735: [Ubuntu 25.10] java/lang/ProcessBuilder/Basic.java, java/lang/ProcessHandle/InfoTest.java fail due to rust-coreutils

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@vpa1977 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@vpa1977 vpa1977 marked this pull request as ready for review June 17, 2025 01:50
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2025

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2025
@vpa1977
Copy link
Contributor Author

vpa1977 commented Jun 17, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@vpa1977
Your change (at version 5d463d9) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

2 participants