Skip to content

8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp #25843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: jdk25
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 17, 2025

Hi all,

This pull request contains a backport of commit a16d2355 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 17 Jun 2025 and was reviewed by Volkan Yazici and Jaikiran Pai.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25843/head:pull/25843
$ git checkout pull/25843

Update a local copy of the PR:
$ git checkout pull/25843
$ git pull https://git.openjdk.org/jdk.git pull/25843/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25843

View PR using the GUI difftool:
$ git pr show -t 25843

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25843.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the jdk25 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a16d23557b101504ed2ff95cf1a3c5ba11afe33d 8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 17, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test-only backport to 25 looks OK to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved @jaikiran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean nio [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants