-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8358627: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26 #25855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8358627: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26 #25855
Conversation
👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add javadoc |
@nizarbenalla |
@nizarbenalla |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout problemlisted-sincecheck-test
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
Once 8346295 is resolved, JavaBaseCheckSince no longer needs to be problemlisted.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25855/head:pull/25855
$ git checkout pull/25855
Update a local copy of the PR:
$ git checkout pull/25855
$ git pull https://git.openjdk.org/jdk.git pull/25855/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25855
View PR using the GUI difftool:
$ git pr show -t 25855
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25855.diff
Using Webrev
Link to Webrev Comment