8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible #25864

prsadhuk · 2025-06-18T03:56:13Z

RBMenuItem's and CBMenuItem's checkmark on the left side are not visible while running on Windows L&F as background color is same as RBMenuItem/CBMenuItem's checkmark..
Modified the color so that they are visible..

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible (Bug - P4)

Reviewers

Tejesh R (@TejeshR13 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25864/head:pull/25864
$ git checkout pull/25864

Update a local copy of the PR:
$ git checkout pull/25864
$ git pull https://git.openjdk.org/jdk.git pull/25864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25864

View PR using the GUI difftool:
$ git pr show -t 25864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25864.diff

Using Webrev

Link to Webrev Comment

…Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible.

bridgekeeper · 2025-06-18T03:57:04Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-18T03:57:17Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible

Reviewed-by: tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

08b1fa4: 8359972: Problem list TestStaticCallStub until JDK-8359963 is fixed
23e1e2f: 8359180: Apply java.io.Serial annotations in java.instrument
5a62e99: 8357686: Remove unnecessary Map.get from AWTAutoShutdown.unregisterPeer
... and 25 more: https://git.openjdk.org/jdk/compare/f62f1178aa01d812ee8ffb1d3dd165b4cf157186...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-06-18T03:57:39Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

prsadhuk · 2025-06-18T04:00:51Z

/touch

openjdk · 2025-06-18T04:01:18Z

@prsadhuk The pull request is being re-evaluated and the inactivity timeout has been reset.

prsadhuk · 2025-06-18T04:02:54Z

/touch

openjdk · 2025-06-18T04:04:08Z

@prsadhuk The pull request is being re-evaluated and the inactivity timeout has been reset.

mlbridge · 2025-06-18T04:06:37Z

Webrevs

lawrence-andrew · 2025-06-18T04:44:07Z

LGTM

TejeshR13 · 2025-06-18T05:31:53Z

test/jdk/javax/swing/JCheckBox/4449413/bug4449413.java

@@ -189,8 +189,8 @@ static AbstractButton createButton(int enabled, int type) {
        };

        b.setOpaque(true);
-        b.setBackground(Color.black);
-        b.setForeground(Color.white);
+        b.setBackground(Color.red);


The test is specifically for background color black, I think you need to retain background color.

The original issue JDK-4449413 was for JCheckBox for black background in MetalLookAndFeel when not using OceanTheme..There was no issue found for JRadioButton, JCheckboxMenuItem, JRadioButtonMenuItem...

JDK-8075915 found issue with other L&F where it fails with "NullPointerException: Can't have null theme" because "Default Metal Theme" is not present in other L&F so initially it was set explicitly to MetalL&F but later setOpaque was added and explicit MetalL&F was removed but there was an issue with WindowL&F which was overlooked and it can be seen in the screenshot pasted in that review.

So, either we can set explicit Metal L&F
but I have chosen to allow other L&F with gray background for WIndows L&F (only for RB and CB MenuItem) which is because for these 2 widgets, WIndowsL&F uses skin which is pre-formatted to black and cannot be color-changed based on foreground/background

TejeshR13

Can remove @author jtreg tag.

TejeshR13

Can use PassFailJFrame.

prsadhuk · 2025-06-19T04:06:44Z

author tag removed..PFJ not required for this time, want to limit this for the fix only..

TejeshR13

LGTM

aivanov-jdk · 2025-06-19T19:24:44Z

Is this fix needed?

You're working on modifying menu rendering on Windows in #23324 so that both check marks and icons are displayed. The test will be fixed as soon as that fix for JDK-8348760 is integrated.

prsadhuk · 2025-06-20T03:08:54Z

No, that is different..In #23324 those are not displayed if imageicon is used, otherwise it is ok..In this, checkmark is not displayed because of the background.
I feel this fix is needed.

prsadhuk · 2025-06-20T03:09:13Z

/integrate

openjdk · 2025-06-20T03:09:59Z

Going to push as commit c51bed7.
Since your change was applied there have been 37 commits pushed to the master branch:

a6464b7: 8358578: Small -XX:NMethodSizeLimit triggers "not in CodeBuffer memory" assert in C1
0dd50db: 8359825: Parallel: Simplify MutableNUMASpace::ensure_parsability
dec42be: 8359394: GC cause cleanup
... and 34 more: https://git.openjdk.org/jdk/compare/f62f1178aa01d812ee8ffb1d3dd165b4cf157186...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-06-20T03:10:08Z

@prsadhuk Pushed as commit c51bed7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on …

57eb73f

…Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible.

openjdk bot added the client [email protected] label Jun 18, 2025

openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025

TejeshR13 reviewed Jun 18, 2025

View reviewed changes

Window L&F fix

92aed6e

TejeshR13 reviewed Jun 19, 2025

View reviewed changes

Remove author tag

d00892d

TejeshR13 approved these changes Jun 19, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2025

openjdk bot added the integrated Pull request has been integrated label Jun 20, 2025

openjdk bot closed this Jun 20, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2025

prsadhuk deleted the JDK-8335986 branch June 20, 2025 03:10

8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible #25864

8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible #25864

Conversation

prsadhuk commented Jun 18, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 18, 2025

Uh oh!

openjdk bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 18, 2025

Uh oh!

prsadhuk commented Jun 18, 2025

Uh oh!

openjdk bot commented Jun 18, 2025

Uh oh!

prsadhuk commented Jun 18, 2025

Uh oh!

openjdk bot commented Jun 18, 2025

Uh oh!

mlbridge bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

lawrence-andrew commented Jun 18, 2025

Uh oh!

TejeshR13 Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

TejeshR13 Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

prsadhuk commented Jun 19, 2025

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk commented Jun 19, 2025

Uh oh!

prsadhuk commented Jun 20, 2025

Uh oh!

prsadhuk commented Jun 20, 2025

Uh oh!

openjdk bot commented Jun 20, 2025

Uh oh!

openjdk bot commented Jun 20, 2025

Uh oh!

Uh oh!

prsadhuk commented Jun 18, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jun 18, 2025 •

edited

Loading

mlbridge bot commented Jun 18, 2025 •

edited

Loading