8358697: TextLayout/MyanmarTextTest.java passes if no Myanmar font is found

[manukumarvs]

Issue:
MyanmarTextTest.java produces a false positive result when some of the test preconditions are not met. It checks whether certain fonts are present in the system, for example, 'Padauk' on Linux. If the required font is missing, the test simply returns early, and the test ends up passing, which is incorrect. Ideally, it should throw a jtreg.SkippedException when the necessary preconditions are not satisfied.

Another scenario is that the test passes on headless machines even though it creates GUI components. Ideally, when GUI components are created in code running on a headless machine, a HeadlessException should be thrown. However, since MyanmarTextTest.java exits before reaching the point where the GUI is created (due to unmet preconditions), it incorrectly reports a pass. This behavior may lead to a misinterpretation of the test as being headless, which it is not.

Fix:
Need to throw jtreg.SkippedException in cases where some pre-conditions for running the test are not met.

Testing:
Tested using mach5 in all available platforms and got full PASS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358697: TextLayout/MyanmarTextTest.java passes if no Myanmar font is found (Bug - P4)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25879/head:pull/25879
$ git checkout pull/25879

Update a local copy of the PR:
$ git checkout pull/25879
$ git pull https://git.openjdk.org/jdk.git pull/25879/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25879

View PR using the GUI difftool:
$ git pr show -t 25879

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25879.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358697: TextLayout/MyanmarTextTest.java passes if no Myanmar font is found

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 2e3bdec: 8358686: CDS and AOT can cause buffer truncation warning even when logging is disabled
• c4fb00a: 8358769: Update --release 25 symbol information for JDK 25 build 26
• 01d4b77: 8319242: HotSpot Style Guide should discourage non-local variables with non-trivial initialization or destruction
• ... and 9 more: https://git.openjdk.org/jdk/compare/984d7f9cdfb0d75ea906ce32df0b6c447f4d5954...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (f38a51a5)
• 04: Full - Incremental (b5a3f894)
• 03: Full - Incremental (bdc40569)
• 02: Full - Incremental (ebd9bc33)
• 01: Full - Incremental (74a5c027)
• 00: Full (b368eece)

[prrace]

I don't understand how what you changed related to the stated problem. In fact I don't see the point of this PR at all.

[manukumarvs]

I don't understand how what you changed related to the stated problem. In fact I don't see the point of this PR at all.

Sorry @prrace, my earlier description was ambiguous. I have updated it. In fact, the issue is about reporting a false positive 'PASSED' result when it should return a 'SKIPPED' result if the preconditions for running the test are not met.

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version f38a51a) is now ready to be sponsored by a Committer.