Skip to content

8355276: Sort C2 includes #25910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Jun 20, 2025

This PR sorts the includes in hotspot/share/opto using test/hotspot/jtreg/sources/SortIncludes.java and enforces sorted includes for C2 sources in sources/TestIncludesAreSorted.java.

Testing:

  • Github Actions
  • tier1,tier2 plus Oracle internal testing on Oracle supported platforms

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25910/head:pull/25910
$ git checkout pull/25910

Update a local copy of the PR:
$ git checkout pull/25910
$ git pull https://git.openjdk.org/jdk.git pull/25910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25910

View PR using the GUI difftool:
$ git pr show -t 25910

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25910.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2025

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355276: Sort C2 includes

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2025
@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@mhaessig The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 20, 2025

Webrevs

@shipilev
Copy link
Member

Oh, great, Windows GHA is apparently failing out with MSVC 14.43 and new runner image. I guess there is no choice but to switch to 14.44 now :) #25912. Wait until GHA is stable again, so to check that MSVC accepts the include order correctly?

@mhaessig
Copy link
Contributor Author

On our internal testing, Windows built and tested fine. I just kicked GHA to rerun the failed Windows builds, which fixed the problem for other runs yesterday.

@mhaessig
Copy link
Contributor Author

Everything passed now.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal [email protected] hotspot-compiler [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants