-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8355276: Sort C2 includes #25910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8355276: Sort C2 includes #25910
Conversation
👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into |
@mhaessig This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Oh, great, Windows GHA is apparently failing out with MSVC |
On our internal testing, Windows built and tested fine. I just kicked GHA to rerun the failed Windows builds, which fixed the problem for other runs yesterday. |
Everything passed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This PR sorts the includes in
hotspot/share/opto
usingtest/hotspot/jtreg/sources/SortIncludes.java
and enforces sorted includes for C2 sources insources/TestIncludesAreSorted.java
.Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25910/head:pull/25910
$ git checkout pull/25910
Update a local copy of the PR:
$ git checkout pull/25910
$ git pull https://git.openjdk.org/jdk.git pull/25910/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25910
View PR using the GUI difftool:
$ git pr show -t 25910
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25910.diff
Using Webrev
Link to Webrev Comment