-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8371425: Include folder names in vscode workspace virtual folders #28194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back krk! A progress list of the required criteria for merging this PR into |
|
@krk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @JornVernee, @shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
erikj79
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change makes sense, but it would be good to get input from other VS Code users.
| -e 's!{{TOPDIR_BASE}}!$(notdir $(TOPDIR))!g' \ | ||
| -e 's!{{OUTPUT_BASE}}!$(notdir $(OUTPUTDIR))!g' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines aren't lining up with the rest. Please see https://openjdk.org/groups/build/doc/code-conventions.html for details on build system code conventions.
erikj79
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/reviewers 2
|
As a VS Code user I welcome this change. The current folder names are fairly nondescript. |
|
/integrate Thanks! |
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, thanks.
|
/sponsor |
|
Going to push as commit 98f40e4.
Your commit was automatically rebased without conflicts. |
|
/backport jdk25u |
|
@krk the backport was successfully created on the branch backport-krk-98f40e45-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u: |
Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from
make vscode-project.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28194/head:pull/28194$ git checkout pull/28194Update a local copy of the PR:
$ git checkout pull/28194$ git pull https://git.openjdk.org/jdk.git pull/28194/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28194View PR using the GUI difftool:
$ git pr show -t 28194Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28194.diff
Using Webrev
Link to Webrev Comment