Skip to content

Conversation

@krk
Copy link

@krk krk commented Nov 7, 2025

Include top-level folder name in the source root, to help distinguishing different vscode instances and include the build configuration name in the "Build artifacts" virtual folder name in vscode, in the generated workspace file from make vscode-project.

image

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8371425: Include folder names in vscode workspace virtual folders (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28194/head:pull/28194
$ git checkout pull/28194

Update a local copy of the PR:
$ git checkout pull/28194
$ git pull https://git.openjdk.org/jdk.git pull/28194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28194

View PR using the GUI difftool:
$ git pr show -t 28194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28194.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@krk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371425: Include folder names in vscode workspace virtual folders

Reviewed-by: erikj, jvernee, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @JornVernee, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@krk The following labels will be automatically applied to this pull request:

  • build
  • ide-support

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2025

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense, but it would be good to get input from other VS Code users.

Comment on lines 87 to 88
-e 's!{{TOPDIR_BASE}}!$(notdir $(TOPDIR))!g' \
-e 's!{{OUTPUT_BASE}}!$(notdir $(OUTPUTDIR))!g' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines aren't lining up with the rest. Please see https://openjdk.org/groups/build/doc/code-conventions.html for details on build system code conventions.

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/reviewers 2

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@erikj79
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 7, 2025
@JornVernee
Copy link
Member

As a VS Code user I welcome this change. The current folder names are fairly nondescript.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2025
@krk
Copy link
Author

krk commented Nov 10, 2025

/integrate

Thanks!

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@krk
Your change (at version 9f39f93) is now ready to be sponsored by a Committer.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

Going to push as commit 98f40e4.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2025
@openjdk openjdk bot closed this Nov 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@shipilev @krk Pushed as commit 98f40e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@krk
Copy link
Author

krk commented Nov 10, 2025

/backport jdk25u

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@krk the backport was successfully created on the branch backport-krk-98f40e45-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 98f40e45 from the openjdk/jdk repository.

The commit being backported was authored by Kerem Kat on 10 Nov 2025 and was reviewed by Erik Joelsson, Jorn Vernee and Aleksey Shipilev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u:

$ git fetch https://github.com/openjdk-bots/jdk25u.git backport-krk-98f40e45-master:backport-krk-98f40e45-master
$ git checkout backport-krk-98f40e45-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk25u.git backport-krk-98f40e45-master

⚠️ @krk You are not yet a collaborator in my fork openjdk-bots/jdk25u. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants