Skip to content

Conversation

@rgangadhar
Copy link
Member

@rgangadhar rgangadhar commented Nov 17, 2025

There are two typos in https://github.com/openjdk/jdk/blob/master/doc/testing.md

https://github.com/openjdk/jdk/blob/master/doc/testing.md?plain=1#L292

Wrong: JTREG_TMIEOUT_FACTOR
Correct: JTREG_TIMEOUT_FACTOR

Wrong: JTREG="TMIEOUT_FACTOR...
Correct: JTREG="TIMEOUT_FACTOR...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371988: Typo in JTREG_TMIEOUT_FACTOR and TMIEOUT_FACTOR should be corrected (Bug - P4) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28351/head:pull/28351
$ git checkout pull/28351

Update a local copy of the PR:
$ git checkout pull/28351
$ git pull https://git.openjdk.org/jdk.git pull/28351/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28351

View PR using the GUI difftool:
$ git pr show -t 28351

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28351.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2025

👋 Welcome back rgangadhar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@rgangadhar The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2025
@rgangadhar
Copy link
Member Author

Pls review this trivial change

@rgangadhar rgangadhar changed the title 8371988: Typo in JTREG_TMIEOUT_FACTOR should be corrected 8371988: Typo in JTREG_TMIEOUT_FACTOR and TMIEOUT_FACTOR should be corrected Nov 17, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2025

Webrevs

@jaikiran
Copy link
Member

Hello Ramesh, that is actually an intentional typo.

but using the keyword format
means that the JTREG variable is parsed and verified for correctness, so
JTREG="TMIEOUT_FACTOR=8" would give an error, while JTREG_TMIEOUT_FACTOR=8
would just pass unnoticed.

What it's trying to explain there is that the usage of JTREG= style will catch and report such typos whereas using JTREG_ will not catch that typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants