8371948: TestStackOverflowDuringInit.java fails xss too small on linux-aarch64 #28352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
On linux-aarch64, when page size is 64K, the minimal java thread stack size is 448K. So this PR increase the minimal java thread stack size in test/hotspot/jtreg/runtime/ClassInitErrors/TestStackOverflowDuringInit.java. Below is the calculation formula for the minimal java thread stack size:
Change has been verified locally both on linux-x64 and linux-aarch64.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28352/head:pull/28352$ git checkout pull/28352Update a local copy of the PR:
$ git checkout pull/28352$ git pull https://git.openjdk.org/jdk.git pull/28352/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28352View PR using the GUI difftool:
$ git pr show -t 28352Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28352.diff
Using Webrev
Link to Webrev Comment