8371720: G1: G1MergeHeapRootsTask::G1ClearBitmapClosure unnecessarily clears marking related data structures #28353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
please review this change that removes resetting concurrent mark state from
G1ClearBitmapClosurethat is responsible for clearing the bitmaps for regions in the collection set.It is unnecessary to clear concurrent mark state in there. All the regions processed here are regions in the collection set, and they are by definition completely excluded from concurrent mark activity. Also see which regions
G1ConcurrentMark::pre_concurrent_start()includes or rather excludes.Testing: tier1-5. gha
Thanks,
Thomas
Progress
Integration blocker
8371720. Please make sure it exists and is accessible.Issue
8371720.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28353/head:pull/28353$ git checkout pull/28353Update a local copy of the PR:
$ git checkout pull/28353$ git pull https://git.openjdk.org/jdk.git pull/28353/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28353View PR using the GUI difftool:
$ git pr show -t 28353Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28353.diff