8372046: compiler/floatingpoint/TestSubNodeFloatDoubleNegation.java fails IR verification

[RealFYang]

Hi, please consider this test-only change fixing an IR test failure.

This IR test fails on platforms without native support for Float16. The reason is that method Float::floatToFloat16 is inlined into method TestSubNodeFloatDoubleNegation.testHalfFloat, which causes unexpected IR graph. One way to fix this would be disabling inlining of methods from the java.lang.Float class.

After this change, we are doing CallStaticJava to convert between Float16 and Float on these platforms:

  ......
  259  CallStaticJava  === 5 6 7 8 1 (22 1 669 1 10 1 22 ) [[ 260 261 262 264 ]] # Static  java.lang.Float::float16ToFloat float ( int ) Float16::floatValue @ bci:4 (line 876) Float16::subtract @ b    ci:1 (line 1185) TestSubNodeFloatDoubleNegation::testHalfFloat @ bci:9 (line 69) !jvms: Float16::floatValue @ bci:4 (line 876) Float16::subtract @ bci:1 (line 1185) TestSubNodeFloatDoubleNegation:    :testHalfFloat @ bci:9 (line 69)

  ......

  562  CallStaticJava  === 553 507 538 8 1 (526 1 1 1 1 559 559 ) [[ 563 564 565 567 ]] # Static  java.lang.Float::floatToFloat16 short ( float ) Float16::valueOf @ bci:5 (line 361) Float16::subtra    ct @ bci:9 (line 1185) TestSubNodeFloatDoubleNegation::testHalfFloat @ bci:12 (line 67) !jvms: Float16::valueOf @ bci:5 (line 361) Float16::subtract @ bci:9 (line 1185) TestSubNodeFloatDoubleNegat    ion::testHalfFloat @ bci:12 (line 67)

  ......

Verified with fastdebug build on aarch64, x86_64 and riscv64 platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372046: compiler/floatingpoint/TestSubNodeFloatDoubleNegation.java fails IR verification (Bug - P4)

Reviewers

• Manuel Hässig (@mhaessig - Committer)
• Emanuel Peter (@eme64 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28364/head:pull/28364
$ git checkout pull/28364

Update a local copy of the PR:
$ git checkout pull/28364
$ git pull https://git.openjdk.org/jdk.git pull/28364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28364

View PR using the GUI difftool:
$ git pr show -t 28364

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28364.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372046: compiler/floatingpoint/TestSubNodeFloatDoubleNegation.java fails IR verification

Reviewed-by: mhaessig, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• 0bff5f3: 8213762: Deprecate Xmaxjitcodesize
• ae4d9c2: 8371918: aarch64: Incorrect pointer dereference in TemplateInterpreterGenerator::generate_native_entry
• 0b3df48: 8372048: Performance improvement on Linux remote desktop
• ... and 32 more: https://git.openjdk.org/jdk/compare/695a4abd5f7e9edcea9f1a724a9ceb87340a8f25...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@RealFYang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3ef234bd)
• 00: Full (f9cefa48)

[TobiHartmann]

Test was added by JDK-8351515, @mhaessig might want to have a look at this.

[mhaessig]

Thank you for looking into this, @RealFYang. The changes look good. I tested locally on x64 with and without FP16 support and just kicked off a CI run. I'll report back with the results in a few hours.

[mhaessig]

Testing passed.

[eme64]

Looks reasonable.

[eme64]

Thanks for the updates :)

[mhaessig]

Changes look good. I reran the CI and everything passed.

[RealFYang]

@mhaessig @eme64 : Thanks for the reviews and testing.
/integrate

[openjdk]

Going to push as commit a3b1aff.
Since your change was applied there have been 44 commits pushed to the master branch:

• 2acd877: 8371440: jpackage should exit with an error if it finds multiple matching signing certificates
• c8e64e7: 8372118: Test tools/jpackage/macosx/DmgContentTest.java failed
• 1535d08: 8371944: AOT configuration is corrupted when app closes System.out
• ... and 41 more: https://git.openjdk.org/jdk/compare/695a4abd5f7e9edcea9f1a724a9ceb87340a8f25...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang Pushed as commit a3b1aff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.