-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372048: Performance improvement on Linux remote desktop #28369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into |
|
@Renjithkannath This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azvegint, @mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@Renjithkannath The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
I'm not familiar with this part of the code, but this might be a good candidate for |
|
/integrate |
|
@Renjithkannath |
|
/sponsor |
|
Going to push as commit 0b3df48.
Your commit was automatically rebased without conflicts. |
|
@azvegint @Renjithkannath Pushed as commit 0b3df48. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi Reviewers,
Observed these two demon threads are created on class initializing time due to static variable and static block call. Observed ScreencastHelper.isAvailable() from XToolkit.java call is enough to start these demon threads on latest Linux (Gnome version 47 and above). In my observation some simple workflows not passing through the code where these Watchers are required, at the same time threads are running because of the above reason. So moving those into lazy loading will improve loading time and performance.
Please review and let me know your suggestions.
Renjith.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28369/head:pull/28369$ git checkout pull/28369Update a local copy of the PR:
$ git checkout pull/28369$ git pull https://git.openjdk.org/jdk.git pull/28369/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28369View PR using the GUI difftool:
$ git pr show -t 28369Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28369.diff
Using Webrev
Link to Webrev Comment