-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8317838: java/nio/channels/Channels/SocketChannelStreams.java running into timeout (aix) #28370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
|
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@RealCLanger To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label add nio |
|
@RealCLanger |
AlanBateman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal looks okay. I see the issue was solved by an OS update so I wonder if this JBS issue should get renamed to say that it removes the test from the ProblemList?
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This removes the problemlist entry for AIX because the underlying issue was solved by OS patches.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28370/head:pull/28370$ git checkout pull/28370Update a local copy of the PR:
$ git checkout pull/28370$ git pull https://git.openjdk.org/jdk.git pull/28370/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28370View PR using the GUI difftool:
$ git pr show -t 28370Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28370.diff
Using Webrev
Link to Webrev Comment