Skip to content

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Nov 18, 2025

ArrayKlass doesn't set AccessFlags so don't look for them there. See CR for details.
Fixed SA and jvmci. @iwanowww Can you check that I changed C2 correctly (we talked about this in August).
Tested with tier1-4. 5-7 in progress.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372098: Move AccessFlags to InstanceKlass (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28371/head:pull/28371
$ git checkout pull/28371

Update a local copy of the PR:
$ git checkout pull/28371
$ git pull https://git.openjdk.org/jdk.git pull/28371/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28371

View PR using the GUI difftool:
$ git pr show -t 28371

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28371.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2025

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

@coleenp The following labels will be automatically applied to this pull request:

  • graal
  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@coleenp coleenp changed the title Move AccessFlags to InstanceKlass 8372098: Move AccessFlags to InstanceKlass Nov 18, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants