Skip to content

Conversation

@hns
Copy link
Member

@hns hns commented Nov 18, 2025

Please review a change to make unqualified anchor references such as {@link ##anchor link} work everywhere. Previously, such links only worked in class pages. The fix consists in attributing the correct Element in JavacTrees::attributeDocReference for references declared in API elements, and setting it to null for references defined in doc-files to make them work as local links.

Because of unattributed doc-files references, we also have to exclude such links from the reference check in DocLint. This is fine because local references always have a target element, and we do not check the anchor anyway.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372055: Fragment link tag does not work in package info (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28372/head:pull/28372
$ git checkout pull/28372

Update a local copy of the PR:
$ git checkout pull/28372
$ git pull https://git.openjdk.org/jdk.git pull/28372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28372

View PR using the GUI difftool:
$ git pr show -t 28372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28372.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2025

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

@hns The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@hns hns marked this pull request as ready for review November 21, 2025 13:31
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant