-
Notifications
You must be signed in to change notification settings - Fork 224
8348303: Remove repeated 'a' from ListSelectionEvent #3590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport. Trivial test change to clean up description. Risk: Low. Tip change was merged in January, but only touches test logic and is quite simple. Testing:
|
Hi @satyenme |
Hi @GoeLin, Thanks for the feedback and point taken - in this case, the description was an oversight on my part. Planning on being more selective with backports moving forward, strongly emphasizing those with a pressing need and reducing the quantity. I'll also go ahead and close this PR. As for testing, I usually cherry-pick the relevant changes and run tier 1 and 2 tests overnight, then push and confirm sanity checks run before PRing. Was looking back, would you mind linking the case you're referring to? |
It is this one: |
Thanks for bringing that to my attention, I seem to have missed actually running that test locally and apologize for that. As you've linked, looks like @phohensee has a pending fix |
Backporting JDK-8348303: Remove repeated 'a' from ListSelectionEvent. Trivial test change to clean up description. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3590/head:pull/3590
$ git checkout pull/3590
Update a local copy of the PR:
$ git checkout pull/3590
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3590/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3590
View PR using the GUI difftool:
$ git pr show -t 3590
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3590.diff
Using Webrev
Link to Webrev Comment