Skip to content

8356096: ISO 4217 Amendment 179 Update #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 22, 2025

I backport this for parity with 17.0.16-oracle.

In 17, CurrencyData.properties is at a different location.
Nevertheless clean backport from 21 with the skara command.
This command understands the information git has about the file move.
Unfortunately the check for cleanness in the PR does not understand it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8356096 needs maintainer approval

Issue

  • JDK-8356096: ISO 4217 Amendment 179 Update (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3603/head:pull/3603
$ git checkout pull/3603

Update a local copy of the PR:
$ git checkout pull/3603
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3603/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3603

View PR using the GUI difftool:
$ git pr show -t 3603

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3603.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 22, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356096: ISO 4217 Amendment 179 Update

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b4ee5241cce000054eb45e50041371e8467e2510 8356096: ISO 4217 Amendment 179 Update May 22, 2025
@openjdk
Copy link

openjdk bot commented May 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 22, 2025
@mlbridge
Copy link

mlbridge bot commented May 22, 2025

Webrevs

@openjdk openjdk bot added the approval label May 24, 2025
Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.
Cheers, Richard.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 26, 2025
@GoeLin
Copy link
Member Author

GoeLin commented May 27, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2025

Going to push as commit b8484be.
Since your change was applied there have been 9 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2025
@openjdk openjdk bot closed this May 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2025
@openjdk
Copy link

openjdk bot commented May 27, 2025

@GoeLin Pushed as commit b8484be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants