Skip to content

8302226: failure_handler native.core should wait for coredump to finish #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 22, 2025

Clean backport to improve testing with failure handler.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8302226 needs maintainer approval

Issue

  • JDK-8302226: failure_handler native.core should wait for coredump to finish (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3604/head:pull/3604
$ git checkout pull/3604

Update a local copy of the PR:
$ git checkout pull/3604
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3604/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3604

View PR using the GUI difftool:
$ git pr show -t 3604

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3604.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 22, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302226: failure_handler native.core should wait for coredump to finish

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6120319afdba98b5ff547b870a0260479e8b683c 8302226: failure_handler native.core should wait for coredump to finish May 22, 2025
@openjdk
Copy link

openjdk bot commented May 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 22, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 22, 2025
@mlbridge
Copy link

mlbridge bot commented May 22, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 23, 2025
@GoeLin
Copy link
Member Author

GoeLin commented May 27, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2025

Going to push as commit 5cce770.
Since your change was applied there have been 6 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2025
@openjdk openjdk bot closed this May 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2025
@openjdk
Copy link

openjdk bot commented May 27, 2025

@GoeLin Pushed as commit 5cce770.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant