Skip to content

8343804: Show the default time zone with -XshowSettings option #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 11, 2025

I backport this for parity with 17.0.17-oracle.

Same edits as in 21 backport. I will make it reference the 21 commit once available, the it should be clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343804 needs maintainer approval

Issue

  • JDK-8343804: Show the default time zone with -XshowSettings option (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3739/head:pull/3739
$ git checkout pull/3739

Update a local copy of the PR:
$ git checkout pull/3739
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3739

View PR using the GUI difftool:
$ git pr show -t 3739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3739.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343804: Show the default time zone with -XshowSettings option

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0329855831102a48abf14b5befc933f84dfd3460 8343804: Show the default time zone with -XshowSettings option Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 11, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 16, 2025
@GoeLin GoeLin changed the title 8343804: Show the default time zone with -XshowSettings option backport ed57c7c4c140186059432d11e00d2fbfc488d094 Jul 17, 2025
@openjdk openjdk bot changed the title backport ed57c7c4c140186059432d11e00d2fbfc488d094 8343804: Show the default time zone with -XshowSettings option Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

This backport pull request has now been updated with issue from the original commit.

@GoeLin
Copy link
Member Author

GoeLin commented Jul 17, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

Going to push as commit 0826b18.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2025
@openjdk openjdk bot closed this Jul 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@GoeLin Pushed as commit 0826b18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8343804 branch July 17, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants