Skip to content

8286660: codestrings gtest fails on AArch64: "udf" in padding #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 15, 2025

I backport this as follow up of JDK-8264207


Progress

  • Change must not contain extraneous whitespace
  • JDK-8286660 needs maintainer approval
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8286660: codestrings gtest fails on AArch64: "udf" in padding

Issue

  • JDK-8286660: codestrings gtest fails on AArch64: "udf" in padding (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3752/head:pull/3752
$ git checkout pull/3752

Update a local copy of the PR:
$ git checkout pull/3752
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3752

View PR using the GUI difftool:
$ git pr show -t 3752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3752.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin changed the base branch from master to pr/3750 July 15, 2025 10:26
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/3750 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286660: codestrings gtest fails on AArch64: "udf" in padding

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the title Goetz backport 8286660 Backport 63cace759ee0a913536171d1e498decb517cc71a Jul 15, 2025
@openjdk openjdk bot changed the title Backport 63cace759ee0a913536171d1e498decb517cc71a 8286660: codestrings gtest fails on AArch64: "udf" in padding Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 15, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Jul 16, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3750 to master July 17, 2025 09:24
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8286660
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Jul 17, 2025
@openjdk openjdk bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Jul 17, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jul 17, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

Going to push as commit 31eba31.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2025
@openjdk openjdk bot closed this Jul 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@GoeLin Pushed as commit 31eba31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8286660 branch July 17, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant