Skip to content

8353713: Improve Currency.getInstance exception handling #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 15, 2025

I backport this for parity with 17.0.17-oracle.

I resolved one test method because in 21 it uses Locale.of which is not in 17.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8353713 needs maintainer approval

Issue

  • JDK-8353713: Improve Currency.getInstance exception handling (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3754/head:pull/3754
$ git checkout pull/3754

Update a local copy of the PR:
$ git checkout pull/3754
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3754/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3754

View PR using the GUI difftool:
$ git pr show -t 3754

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3754.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 5cac579619164b9a664327a4f71c4de7e7575276 8353713: Improve Currency.getInstance exception handling Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 15, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant