-
Notifications
You must be signed in to change notification settings - Fork 231
8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8359402: Test CloseDescriptors.java should throw SkippedException when there is no lsof/sctp #3769
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 63 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
Webrevs
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/approval request Clean backport make test report SkippedException when test can not run without lsof command. Test-fix only, change has been verified locally, no risk. |
@sendaoYan |
@sendaoYan This pull request has not yet been marked as ready for integration. |
Thanks for the approved. /integrate |
Going to push as commit c7d6411.
Your commit was automatically rebased without conflicts. |
@sendaoYan Pushed as commit c7d6411. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 36b185a9 from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 20 Jun 2025 and was reviewed by Jaikiran Pai.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3769/head:pull/3769
$ git checkout pull/3769
Update a local copy of the PR:
$ git checkout pull/3769
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3769/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3769
View PR using the GUI difftool:
$ git pr show -t 3769
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3769.diff
Using Webrev
Link to Webrev Comment