Skip to content

Conversation

satyenme
Copy link

@satyenme satyenme commented Sep 11, 2025

Backporting JDK-8353309: Open source several Swing text tests. Adds five swing text related tests. Ran GHA Sanity Checks, local Tier 1 and 2, and new tests directly. Patch is not clean, but trivial fix: there's a typo in one of the tests addressed by JDK-8359418 that I've included here. Backporting for parity with Oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8359418 needs maintainer approval
  • JDK-8353309 needs maintainer approval

Issues

  • JDK-8353309: Open source several Swing text tests (Bug - P4)
  • JDK-8359418: Test "javax/swing/text/GlyphView/bug4188841.java" failed because the phrase of text pane does not match the instructions (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3916/head:pull/3916
$ git checkout pull/3916

Update a local copy of the PR:
$ git checkout pull/3916
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3916/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3916

View PR using the GUI difftool:
$ git pr show -t 3916

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3916.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 31a6de2e743923c92e976d5f5536120736d56029 8353309: Open source several Swing text tests Sep 11, 2025
@openjdk
Copy link

openjdk bot commented Sep 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 11, 2025
@satyenme
Copy link
Author

/issue add 8359418

@mlbridge
Copy link

mlbridge bot commented Sep 11, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@satyenme
Adding additional issue to issue list: 8359418: Test "javax/swing/text/GlyphView/bug4188841.java" failed because the phrase of text pane does not match the instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant