Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 12, 2025

I had to resolve three files and adapt the tests to compile (see extra commit)

test/hotspot/jtreg/serviceability/dcmd/framework/VMVersionTest.java
Resolved test instructions as later change was already backported.

test/jdk/java/lang/module/ModuleDescriptorTest.java
Several resolves. Some previous changes that can not be backported.

test/lib/jdk/test/lib/util/ModuleInfoWriter.java
Resolved


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8304163 needs maintainer approval

Issue

  • JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3917/head:pull/3917
$ git checkout pull/3917

Update a local copy of the PR:
$ git checkout pull/3917
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3917

View PR using the GUI difftool:
$ git pr show -t 3917

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3917.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 622f239448c2a96a74202621ee84c181d79fbde4 8304163: Move jdk.internal.module.ModuleInfoWriter to the test library Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 12, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 13, 2025

GHA failure: Annotations test needs adption.
linux-x64,
macos-aarch64
macos-x64
windows-x64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant