8304163: Move jdk.internal.module.ModuleInfoWriter to the test library #3917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to resolve three files and adapt the tests to compile (see extra commit)
test/hotspot/jtreg/serviceability/dcmd/framework/VMVersionTest.java
Resolved test instructions as later change was already backported.
test/jdk/java/lang/module/ModuleDescriptorTest.java
Several resolves. Some previous changes that can not be backported.
test/lib/jdk/test/lib/util/ModuleInfoWriter.java
Resolved
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3917/head:pull/3917
$ git checkout pull/3917
Update a local copy of the PR:
$ git checkout pull/3917
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3917/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3917
View PR using the GUI difftool:
$ git pr show -t 3917
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3917.diff
Using Webrev
Link to Webrev Comment