Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 12, 2025

I backport this for parity with 17.0.18-oracle.

Needed to resolve as "8304888: Add dedicated VMProps for linker and fallback linker" is not in 17.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8338428 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338428: Add logging of final VM flags while setting properties (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3922/head:pull/3922
$ git checkout pull/3922

Update a local copy of the PR:
$ git checkout pull/3922
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3922

View PR using the GUI difftool:
$ git pr show -t 3922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3922.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 48277018a5a3fe861ebe9bf0860a2809611fb66f 8338428: Add logging of final VM flags while setting properties Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 12, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant