-
Notifications
You must be signed in to change notification settings - Fork 231
8333446: Add tests for hierarchical container support #3926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
87db152
to
d8d0414
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Webrevs
|
d8d0414
to
3a1cc18
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
Hmm, those tests will fail on cgv2 without https://bugs.openjdk.org/browse/JDK-8322420 |
OK, JDK-8322420 is a larger one, and it needs two other changes. So this makes no sense. I think at least |
Yes. I suggest to not backport this. |
I backport this to improve testing in 17 and make later backports clean and easier.
Clean backport of the 21u commit.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3926/head:pull/3926
$ git checkout pull/3926
Update a local copy of the PR:
$ git checkout pull/3926
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3926/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3926
View PR using the GUI difftool:
$ git pr show -t 3926
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3926.diff
Using Webrev
Link to Webrev Comment