8317678: Fix up hashCode() for ZipFile.Source.Key

[rm-gh-8]

Backporting JDK-8317678: Fix up hashCode() for ZipFile.Source.Key. Fixes the hashCode() implementation and adds a new benchmark test. Ran GHA Sanity Checks (passed), related zip tests (passed) and the new benchmark test (executed properly). The merge conflict was due to the missing benchmark test file, which is in this PR.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317678 needs maintainer approval

Issue

• JDK-8317678: Fix up hashCode() for ZipFile.Source.Key (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4169/head:pull/4169
$ git checkout pull/4169

Update a local copy of the PR:
$ git checkout pull/4169
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4169

View PR using the GUI difftool:
$ git pr show -t 4169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4169.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (a75d78b1)
• 01: Full - Incremental (e9f799ba)
• 00: Full (36d69b86)

[rm-gh-8]

/approval request for backport of JDK-8317678: Fix up hashCode() for ZipFile.Source.Key.

Ran the related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/java/util/Calendar

Ran the new benchmark tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Successful) java -jar build/*/images/test/micro/benchmarks.jar java.util.zip.ZipFileOpen

Results are attached.
linux-aarch64-microbench-test.log
linux-aarch64-specific-test.log
linux-x64-microbench-test.log
linux-x64-specific-test.log
macos-aarch64-microbench-test.log
macos-aarch64-specific-test.log
windows-x64-microbench-test.log
windows-x64-specific-test.log

[openjdk]

@rm-gh-8
8317678: The approval request has been created successfully.

[phohensee]

The maintainers don't usually approve including a test in a backport which doesn't exist in the target repo, so I'd remove ZipFileOpen.java from the PR. If you do want to include ZipFileOpen.java in this PR, I'd first backport it via JDK-8300493, and merge that into this PR.

[rm-gh-8]

The maintainers don't usually approve including a test in a backport which doesn't exist in the target repo, so I'd remove ZipFileOpen.java from the PR. If you do want to include ZipFileOpen.java in this PR, I'd first backport it via JDK-8300493, and merge that into this PR.

Removed ZipFileOpen.java. JDK-8300493 is not on the prioritized list.