8365790: Shutdown hook for application image does not work on Windows

[GoeLin]

Resolved line 274 in TKit.java

The test part of the change does not compile. In TKit, I needed to replace Thread.sleep(Duration) and Duration.isPositive().

Update: I needed another test fix to make the tests compile on windows. Testing passes now, including all SAP nightlies.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8365790 needs maintainer approval

Issue

• JDK-8365790: Shutdown hook for application image does not work on Windows (Bug - P3 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4190/head:pull/4190
$ git checkout pull/4190

Update a local copy of the PR:
$ git checkout pull/4190
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4190

View PR using the GUI difftool:
$ git pr show -t 4190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4190.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365790: Shutdown hook for application image does not work on Windows

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 4272f8c: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16
• e9c962c: 8308633: Increase precision of timestamps in g1 log
• fd86129: 8317264: Pattern.Bound has static fields that should be static final.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (d94c4088)
• 01: Full - Incremental (4f2bc3ac)
• 00: Full (1b586c8f)

[MBaesken]

compared to 21u-dev, was UseShutdownHook omitted because Win8365790Test is omitted too ?

[GoeLin]

Sorry, just forgot to add the files when I copied the local draft patch into the nicyfied PR.

[MBaesken]

Thanks for adding the missing files. LGTM.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 78564fd25007b517b774b3d29cffe319a4c2b17a.
Since your change was applied there have been 4 commits pushed to the master branch:

• bc6cb61: 8352682: Opensource JComponent tests
• 4272f8c: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16
• e9c962c: 8308633: Increase precision of timestamps in g1 log
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/a0082e675ddf14540bcdc70fb7b56663943631ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 78564fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.