Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Nov 19, 2025

Backporting JDK-8290079: Reduce interaction with volatile in static initializer of BigInteger.

BigInteger.powerCache is volatile and should be assigned only once in static initializer.

Ran GHA Sanity Checks (passed) and related test (passed).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8290079 needs maintainer approval

Issue

  • JDK-8290079: Reduce interaction with volatile in static initializer of BigInteger (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4191/head:pull/4191
$ git checkout pull/4191

Update a local copy of the PR:
$ git checkout pull/4191
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4191

View PR using the GUI difftool:
$ git pr show -t 4191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4191.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c83fcbd18fff4d10c4162c43ddcdf3a51ce2c8e6 8290079: Reduce interaction with volatile in static initializer of BigInteger Nov 19, 2025
@openjdk
Copy link

openjdk bot commented Nov 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 19, 2025
@rm-gh-8 rm-gh-8 marked this pull request as ready for review November 19, 2025 23:09
@openjdk
Copy link

openjdk bot commented Nov 19, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2025

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 19, 2025

/approval request for backport of JDK-8290079: Reduce interaction with volatile in static initializer of BigInteger.

Ran the related tests:

(Passed) - make test TEST=test/jdk/java/math/BigInteger

Results are attached.
macos-aarch64-specific-test.log

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@rm-gh-8
8290079: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant