Skip to content

Conversation

@suchismith1993
Copy link

@suchismith1993 suchismith1993 commented Oct 27, 2025

Hi all,

This pull request contains a backport of commit d45e65ba from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 8 Oct 2025 and was reviewed by Joachim Kern, Martin Doerr and Matthias Baesken.

Thanks!


Progress

  • JDK-8030957 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8030957: AIX: Implement OperatingSystemMXBean.getSystemCpuLoad() and .getProcessCpuLoad() on AIX (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2403/head:pull/2403
$ git checkout pull/2403

Update a local copy of the PR:
$ git checkout pull/2403
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2403

View PR using the GUI difftool:
$ git pr show -t 2403

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2403.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@suchismith1993 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8030957: AIX: Implement OperatingSystemMXBean.getSystemCpuLoad() and .getProcessCpuLoad() on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d45e65bab45f78f9f378cdc53837fe33190b7801 8030957: AIX: Implement OperatingSystemMXBean.getSystemCpuLoad() and .getProcessCpuLoad() on AIX Oct 27, 2025
@openjdk
Copy link

openjdk bot commented Oct 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 27, 2025
@openjdk
Copy link

openjdk bot commented Oct 27, 2025

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

@suchismith1993
Copy link
Author

/approval request "This feature is needed for customer builds"

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@suchismith1993
8030957: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 27, 2025
@TheRealMDoerr
Copy link
Contributor

Backport to jdk25u needs to be done before jdk21u-dev.

@GoeLin
Copy link
Member

GoeLin commented Oct 28, 2025

Can you please add a complete approval request text as described here? https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
I remove the label in the meantime. Thanks.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Oct 28, 2025
@suchismith1993
Copy link
Author

/approval request Critical fix as customers are unable to fetch cpu usage for AIX.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@suchismith1993
8030957: The approval request has been updated successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 29, 2025
@GoeLin
Copy link
Member

GoeLin commented Oct 30, 2025

Hi @suchismith1993 , please label again for approval once it is approved for 25. Also, please state risk and testing in your approval request.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Oct 30, 2025
@suchismith1993
Copy link
Author

/approval request AIX CPU load support using libperfstat (needed for MXBean metrics); low risk, verified on AIX with jtreg and topas.

@openjdk
Copy link

openjdk bot commented Nov 1, 2025

@suchismith1993
8030957: The approval request has been updated successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 1, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2025

@suchismith1993 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@suchismith1993
Copy link
Author

/approval request AIX CPU load support using libperfstat (needed for MXBean metrics); low risk, verified on AIX with jtreg and topas.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

@suchismith1993
8030957: The approval request was already up to date.

@suchismith1993
Copy link
Author

Hi @GoeLin Changes made it to jdk25u. Can we get this integrated now ?

@GoeLin
Copy link
Member

GoeLin commented Dec 15, 2025

Hi, please merge head and await the GHA tests before pushing.
Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2025
@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants