Skip to content

Conversation

@jyma22
Copy link

@jyma22 jyma22 commented Dec 9, 2025

Hi all,

This pull request contains a backport of commit 0c6d1b9c from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 28 Nov 2025 and was reviewed by Tejesh R, Jayathirth D V and Alexander Zvegintsev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371759 needs maintainer approval

Issue

  • JDK-8371759: Add missing @Override annotations in com.sun.imageio package (Bug - P5 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2511/head:pull/2511
$ git checkout pull/2511

Update a local copy of the PR:
$ git checkout pull/2511
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2511

View PR using the GUI difftool:
$ git pr show -t 2511

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2511.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2025

👋 Welcome back jyma22! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 0c6d1b9c8bfd7f4e39a6621c7a8f7bdcd044a05f 8371759: Add missing @Override annotations in com.sun.imageio package Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 10, 2025
@openjdk
Copy link

openjdk bot commented Dec 10, 2025

⚠️ @jyma22 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2025

Webrevs

@jyma22
Copy link
Author

jyma22 commented Dec 10, 2025

/approval request This patch adds missing @OverRide annotations to methods in the com.sun.imageio package that override methods from a superclass or interface.
Only source annotations are added; there are no behavioral changes.
Passed tier 1-4

@openjdk
Copy link

openjdk bot commented Dec 10, 2025

@jyma22
8371759: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants