-
Notifications
You must be signed in to change notification settings - Fork 148
8372977: Unnecessary gthread-2.0 loading #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8372977: Unnecessary gthread-2.0 loading #2515
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
Webrevs
|
schmelter-sap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I backport this for parity with 21.0.11-oracle.
Update: The clean backport breaks the build. There are two gtk implementations in
OpenJDK 21: gtk2 and gtk3. This change adresses gtk3, see description in
original JBS issue. Gtk2 was removed in 8329471: "Remove GTK2" in 24.
Gtk2 implements the same functions as gtk3, so we can not remove
the decls in the header. See second commit.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2515/head:pull/2515$ git checkout pull/2515Update a local copy of the PR:
$ git checkout pull/2515$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2515/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2515View PR using the GUI difftool:
$ git pr show -t 2515Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2515.diff
Using Webrev
Link to Webrev Comment