Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 15, 2025

Hi all,

This pull request contains a backport of commit 34f24131 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 15 Dec 2025 and was reviewed by Leonid Mesnik and David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371503 needs maintainer approval

Issue

  • JDK-8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2518/head:pull/2518
$ git checkout pull/2518

Update a local copy of the PR:
$ git checkout pull/2518
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2518

View PR using the GUI difftool:
$ git pr show -t 2518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2518.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 34f241317ecd7473cfb6dcc2e6e5cf3a40299e2c 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant